mridulm commented on code in PR #36165:
URL: https://github.com/apache/spark/pull/36165#discussion_r1029927503
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -282,6 +280,17 @@ final class ShuffleBlockFetcherIterator(
}
}
+ @inline def updateMergedReqsDuration(wasReqForMergedChunks: Boolean =
false): Unit = {
+ if (remainingBlocks.isEmpty) {
+ val durationMs = TimeUnit.NANOSECONDS.toMillis(clock.nanoTime() -
requestStartTime)
+ if (wasReqForMergedChunks) {
+ shuffleMetrics.incRemoteMergedReqsDuration(durationMs)
+ } else {
+ shuffleMetrics.incRemoteReqsDuration(durationMs)
+ }
Review Comment:
`shuffleLocalMetricsUpdate` and `shuffleRemoteMetricsUpdate` is treating
merged fetches as a subset of all fetches - while here we are treating them
seperately.
Any particular reason for this difference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
