amaliujia commented on PR #38763: URL: https://github.com/apache/spark/pull/38763#issuecomment-1324432409
LGTM If you are interested in, can you BTW follow up in this PR on https://github.com/apache/spark/blob/2c8da56d6f3136eb7b97f9c06d131c767ce459b2/python/pyspark/sql/tests/connect/test_connect_basic.py#L212 Basically I think ``` self.assert_eq( cdf.drop(cdf.a, cdf.x).toPandas(), sdf.drop("a", "x").toPandas(), ) ``` these two case are not equivalent? They should be ``` Basically I think ``` self.assert_eq( cdf.drop(cdf.a, cdf.x).toPandas(), sdf.drop(cdf.a, cdf.x).toPandas(), ) ``` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
