amaliujia commented on code in PR #38686: URL: https://github.com/apache/spark/pull/38686#discussion_r1029946709
########## python/pyspark/sql/connect/dataframe.py: ########## @@ -255,10 +255,21 @@ def distinct(self) -> "DataFrame": ) def drop(self, *cols: "ColumnOrString") -> "DataFrame": Review Comment: I think we have built the consensus that we prefer re-using the proto than ask clients do duplicate work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org