zhengruifeng commented on code in PR #38757: URL: https://github.com/apache/spark/pull/38757#discussion_r1030020312
########## python/pyspark/sql/connect/column.py: ########## @@ -15,14 +15,15 @@ # limitations under the License. # import uuid -from typing import cast, get_args, TYPE_CHECKING, Callable, Any +from typing import cast, TYPE_CHECKING, Callable, Any import json import decimal import datetime import pyspark.sql.connect.proto as proto -from pyspark.sql.connect._typing import PrimitiveType + +primitive_types = (bool, float, int, str) Review Comment: list the types here to avoid a `circular import`, since `_typing` also import column -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
