MaxGekk commented on code in PR #38576:
URL: https://github.com/apache/spark/pull/38576#discussion_r1030039032
##########
sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala:
##########
@@ -964,17 +964,14 @@ class SubquerySuite extends QueryTest
| WHERE t1.c1 = t2.c1)
""".stripMargin)
}
- checkErrorMatchPVals(
+ checkError(
exception1,
- errorClass =
"UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_CORRELATED_REFERENCE",
- parameters = Map("treeNode" -> "(?s).*"),
- sqlState = None,
+ errorClass =
"UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.CORRELATED_REFERENCE",
+ parameters = Map("sqlExprs" -> "outer(arr_c2#427264)"),
Review Comment:
the same question here. Can we guarantee the same number across multiple
runs.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveSubquerySuite.scala:
##########
@@ -51,11 +51,13 @@ class ResolveSubquerySuite extends AnalysisTest {
test("SPARK-17251 Improve `OuterReference` to be `NamedExpression`") {
val expr = Filter(
InSubquery(Seq(a), ListQuery(Project(Seq(UnresolvedAttribute("a")),
t2))), t1)
- val m = intercept[AnalysisException] {
- SimpleAnalyzer.checkAnalysis(SimpleAnalyzer.ResolveSubquery(expr))
- }.getMessage
- assert(m.contains(
- "Expressions referencing the outer query are not supported outside of
WHERE/HAVING clauses"))
+ checkError(
+ exception = intercept[AnalysisException] {
+ SimpleAnalyzer.checkAnalysis(SimpleAnalyzer.ResolveSubquery(expr))
+ },
+ errorClass =
"UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.CORRELATED_REFERENCE",
+ parameters = Map("sqlExprs" -> "outer(a#4151672)")
Review Comment:
Is the number `4151672` stable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
