yabola commented on code in PR #38560:
URL: https://github.com/apache/spark/pull/38560#discussion_r1030393536
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -712,6 +794,7 @@ public MergeStatuses
finalizeShuffleMerge(FinalizeShuffleMerge msg) {
mergeStatuses = new MergeStatuses(msg.shuffleId, msg.shuffleMergeId,
bitmaps.toArray(new RoaringBitmap[bitmaps.size()]),
Ints.toArray(reduceIds),
Longs.toArray(sizes));
+
appShuffleInfo.shuffles.get(msg.shuffleId).setFinalizedPartitions(Ints.toArray(reduceIds));
Review Comment:
Thanks for your review @wankunde !
Yes, if we need to solve this situation completely, we need to store
finalized partitions in db.
But on the other hand, when Application removed, all the merged data will be
cleaned up finally.
I'm not sure if we can just ignore this case to simplify the logic since it
will finally be cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
