srielau commented on code in PR #38760:
URL: https://github.com/apache/spark/pull/38760#discussion_r1030596213
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala:
##########
@@ -3537,6 +3537,12 @@ class DataFrameSuite extends QueryTest
}.isEmpty)
}
}
+
+ test("SPARK-41219: Decimal changePrecision should work with decimal(0, 0)") {
+ val df = Seq("0.5944910").toDF("a")
+ checkAnswer(df.selectExpr("cast(a as decimal(7,7)) div 100"), Row(0))
+ checkAnswer(df.select(lit(BigDecimal(0)) as "c").selectExpr("cast(c as
decimal(0,0))"), Row(0))
Review Comment:
The numeric equivalent to CHAR(0). The only values are NULL and 0. I would
choose the path of least resistance. I agree that there is risk in support.
What's the origin of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
