zhengruifeng commented on code in PR #38778:
URL: https://github.com/apache/spark/pull/38778#discussion_r1031016264
##########
python/pyspark/sql/tests/connect/test_connect_plan_only.py:
##########
@@ -58,6 +58,12 @@ def test_join_condition(self):
)._plan.to_proto(self.connect)
self.assertIsNotNone(plan.root.join.join_condition)
+ def test_crossjoin(self):
+ left_input = self.connect.readTable(table_name=self.tbl_name)
+ right_input = self.connect.readTable(table_name=self.tbl_name)
+ plan =
left_input.crossJoin(other=right_input)._plan.to_proto(self.connect)
+ self.assertEqual(plan.root.join.join_type, 7) # JOIN_TYPE_CROSS
+
Review Comment:
after this PR, `DataFrame.join` also support `cross`, I think we can also
add a test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
