amaliujia commented on code in PR #38768:
URL: https://github.com/apache/spark/pull/38768#discussion_r1031035663
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -558,29 +557,19 @@ def _repr_html_(self) -> str:
class Aggregate(LogicalPlan):
- MeasureType = Tuple["ExpressionOrString", str]
- MeasuresType = Sequence[MeasureType]
- OptMeasuresType = Optional[MeasuresType]
-
def __init__(
self,
child: Optional["LogicalPlan"],
grouping_cols: List[Column],
- measures: OptMeasuresType,
Review Comment:
This is a sequence now and I think it can be len=0 which is empty measures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
