amaliujia commented on code in PR #38793:
URL: https://github.com/apache/spark/pull/38793#discussion_r1031931607
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -457,3 +458,16 @@ message RenameColumnsByNameToNameMap {
// duplicated B are not allowed.
map<string, string> rename_columns_map = 2;
}
+
+// Adding columns or replacing the existing columns that has the same names.
+message WithColumns {
+ // (Required) The input relation.
+ Relation input = 1;
+
+ // (Required)
+ //
+ // Given a column name, apply corresponding expression on the column. If
column
+ // name exists in the input relation, then replacing the column. if column
name
+ // does not exist in the input relation, then adding the column.
+ map<string, Expression> cols_map = 2;
Review Comment:
I see the reason to move to list of named expressions.
I also want to point out another thing so we have comprehensive discussion:
a list of named expressions means there could be duplicates while current
API contract does not support duplicates. If an implementation submits a list
of named expressions which contains duplicates, we gonna need to define a way
to dedup. The best is if we can define a sorted unique map but maybe that is
not easy to achieve by proto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
