gengliangwang commented on code in PR #38779:
URL: https://github.com/apache/spark/pull/38779#discussion_r1032107747
##########
project/SparkBuild.scala:
##########
@@ -611,9 +611,23 @@ object SparkParallelTestGrouping {
object Core {
import scala.sys.process.Process
+ import BuildCommons.protoVersion
def buildenv = Process(Seq("uname")).!!.trim.replaceFirst("[^A-Za-z0-9].*",
"").toLowerCase
def bashpath = Process(Seq("where",
"bash")).!!.split("[\r\n]+").head.replace('\\', '/')
lazy val settings = Seq(
+ // Setting version for the protobuf compiler. This has to be propagated to
every sub-project
+ // even if the project is not using it.
+ PB.protocVersion := BuildCommons.protoVersion,
Review Comment:
Yes, both connect and protobuf connector have these code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
