zero323 commented on code in PR #38020:
URL: https://github.com/apache/spark/pull/38020#discussion_r1032612453
##########
python/pyspark/sql/dataframe.py:
##########
@@ -3175,12 +3177,12 @@ def melt(
Parameters
----------
- ids : str, Column, tuple, list, optional
- Column(s) to use as identifiers. Can be a single column or column
name,
- or a list or tuple for multiple columns.
- values : str, Column, tuple, list, optional
- Column(s) to unpivot. Can be a single column or column name, or a
list or tuple
- for multiple columns. If not specified or empty, uses all columns
that
+ ids : str, list, tuple, optional
+ Column name(s) to use as identifiers. Can be a single column name,
+ or a list or tuple for multiple column names.
+ values : str, list, tuple, optional
Review Comment:
We could also provide defaults for this and the following arguments:
```python
def unpivot(
self,
ids: Optional[Union[str, List[str], Tuple[str, ...]]],
values: Optional[Union[str, List[str], Tuple[str, ...]]] = None,
variableColumnName: str = "variable",
valueColumnName: str = "value",
) -> "DataFrame":
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
