LuciferYang commented on code in PR #38782:
URL: https://github.com/apache/spark/pull/38782#discussion_r1032911158


##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -637,6 +637,32 @@ class QueryExecutionErrorsSuite
       sqlState = "0A000")
   }
 
+  test("FAILED_RENAME_PATH: rename when destination path already exists") {
+    withTempPath { p =>
+      withSQLConf(
+        "spark.sql.streaming.checkpointFileManagerClass" -> 
classOf[FileSystemBasedCheckpointFileManager].getName,

Review Comment:
   
https://github.com/apache/spark/blob/9af216d7ac26f0ec916833c2e80a01aef8933529/sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala#L451-L454
   
   hmm..  because the scalastyle check is off in line 451 and only the 
throwerror related check is on in line 454, the line 643 and line 651 are more 
than 100 characters long but not checked
   
   @ibuder please fix the code style of line 643 and line 651 (File line length 
exceeds 100 characters)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to