Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6242#discussion_r30545444
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateUtils.scala 
---
    @@ -41,8 +41,9 @@ object DateUtils {
       }
     
       // we should use the exact day as Int, for example, (year, month, day) 
-> day
    -  def millisToDays(millisLocal: Long): Int = {
    -    ((millisLocal + LOCAL_TIMEZONE.get().getOffset(millisLocal)) / 
MILLIS_PER_DAY).toInt
    +  def millisToDays(millisUtc: Long): Int = {
    +    // SPARK-6785: use Math.floor so negative number of days (dates before 
1970) work as input for function toJavaDate(Int)
    --- End diff --
    
    This line is too long


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to