zhengruifeng commented on code in PR #38819:
URL: https://github.com/apache/spark/pull/38819#discussion_r1033287401
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -440,6 +441,26 @@ message NAFill {
repeated Expression.Literal values = 3;
}
+
+// Drop rows containing null values.
+// It will invoke 'Dataset.na.drop' (same as 'DataFrameNaFunctions.drop') to
compute the results.
+message NADrop {
Review Comment:
since parameter `how: String` can be converted to `min_non_nulls`
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala#L491-L497
only `min_non_nulls` is needed in proto message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
