MaxGekk commented on code in PR #38728:
URL: https://github.com/apache/spark/pull/38728#discussion_r1033737542
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -132,7 +132,97 @@
},
"INTERCEPTOR_RUNTIME_ERROR" : {
"message" : [
- "Error instantiating GRPC interceptor: <msg>"
+ "Error instantiating GRPC interceptor: <msg>."
+ ]
+ },
+ "INVALID_COMMAND_WRITE_INVALID_BUCKET_BY" : {
+ "message" : [
+ "BucketBy must specify a bucket count > 0, received <bucket>
instead."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT" : {
+ "message" : [
+ "Deduplicate must be called with either all or a subset of column
names to deduplicate."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT_COLUMN" : {
+ "message" : [
+ "Invalid column name used for Deduplicate: <col>."
+ ]
+ },
+ "INVALID_PLAN_EMPTY_INPUT" : {
+ "message" : [
+ "Input relation must not be empty."
+ ]
+ },
+ "INVALID_PLAN_INPUT" : {
+ "message" : [
+ "Error transforming Spark Connect plan: <msg>."
+ ]
+ },
+ "INVALID_PLAN_INVALID_ALIAS" : {
+ "message" : [
+ "Alias expressions with more than 1 identifier must not use optional
metadata."
+ ]
+ },
+ "INVALID_PLAN_INVALID_DATA_SOURCE" : {
+ "message" : [
+ "Read from DataSource requires a format parameter."
+ ]
+ },
+ "INVALID_PLAN_INVALID_JOIN_CONDITION" : {
+ "message" : [
+ "Using columns or join conditions cannot be set at the same time in
Join."
+ ]
+ },
+ "INVALID_PLAN_INVALID_SET_OPERATION" : {
+ "message" : [
+ "Invalid Set operation: <type> does not support <param>."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_EMPTY" : {
Review Comment:
Is it tested somewhere? If not, could add a test, please.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -132,7 +132,97 @@
},
"INTERCEPTOR_RUNTIME_ERROR" : {
"message" : [
- "Error instantiating GRPC interceptor: <msg>"
+ "Error instantiating GRPC interceptor: <msg>."
+ ]
+ },
+ "INVALID_COMMAND_WRITE_INVALID_BUCKET_BY" : {
+ "message" : [
+ "BucketBy must specify a bucket count > 0, received <bucket>
instead."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT" : {
+ "message" : [
+ "Deduplicate must be called with either all or a subset of column
names to deduplicate."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT_COLUMN" : {
+ "message" : [
+ "Invalid column name used for Deduplicate: <col>."
+ ]
+ },
+ "INVALID_PLAN_EMPTY_INPUT" : {
+ "message" : [
+ "Input relation must not be empty."
+ ]
+ },
+ "INVALID_PLAN_INPUT" : {
+ "message" : [
+ "Error transforming Spark Connect plan: <msg>."
+ ]
+ },
+ "INVALID_PLAN_INVALID_ALIAS" : {
+ "message" : [
+ "Alias expressions with more than 1 identifier must not use optional
metadata."
+ ]
+ },
+ "INVALID_PLAN_INVALID_DATA_SOURCE" : {
+ "message" : [
+ "Read from DataSource requires a format parameter."
+ ]
+ },
+ "INVALID_PLAN_INVALID_JOIN_CONDITION" : {
+ "message" : [
+ "Using columns or join conditions cannot be set at the same time in
Join."
+ ]
+ },
+ "INVALID_PLAN_INVALID_SET_OPERATION" : {
+ "message" : [
+ "Invalid Set operation: <type> does not support <param>."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_EMPTY" : {
+ "message" : [
+ "Values must contains at least 1 item."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_SIZE" : {
Review Comment:
Is there a test for the error?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -132,7 +132,97 @@
},
"INTERCEPTOR_RUNTIME_ERROR" : {
"message" : [
- "Error instantiating GRPC interceptor: <msg>"
+ "Error instantiating GRPC interceptor: <msg>."
+ ]
+ },
+ "INVALID_COMMAND_WRITE_INVALID_BUCKET_BY" : {
+ "message" : [
+ "BucketBy must specify a bucket count > 0, received <bucket>
instead."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT" : {
+ "message" : [
+ "Deduplicate must be called with either all or a subset of column
names to deduplicate."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT_COLUMN" : {
+ "message" : [
+ "Invalid column name used for Deduplicate: <col>."
+ ]
+ },
+ "INVALID_PLAN_EMPTY_INPUT" : {
+ "message" : [
+ "Input relation must not be empty."
+ ]
+ },
+ "INVALID_PLAN_INPUT" : {
+ "message" : [
+ "Error transforming Spark Connect plan: <msg>."
+ ]
+ },
+ "INVALID_PLAN_INVALID_ALIAS" : {
+ "message" : [
+ "Alias expressions with more than 1 identifier must not use optional
metadata."
+ ]
+ },
+ "INVALID_PLAN_INVALID_DATA_SOURCE" : {
+ "message" : [
+ "Read from DataSource requires a format parameter."
+ ]
+ },
+ "INVALID_PLAN_INVALID_JOIN_CONDITION" : {
+ "message" : [
+ "Using columns or join conditions cannot be set at the same time in
Join."
+ ]
+ },
+ "INVALID_PLAN_INVALID_SET_OPERATION" : {
+ "message" : [
+ "Invalid Set operation: <type> does not support <param>."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_EMPTY" : {
+ "message" : [
+ "Values must contains at least 1 item."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_SIZE" : {
+ "message" : [
+ "When values contains more than 1 items, values and cols should have
the same length."
+ ]
+ },
+ "INVALID_PLAN_UNKNOWN_RELATION" : {
+ "message" : [
+ "Relation: <param> not supported."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_DATA_SOURCE" : {
+ "message" : [
+ "Unsupported input data source: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_EXPRESSION_TYPE" : {
Review Comment:
Could you add a test for this, please
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -132,7 +132,97 @@
},
"INTERCEPTOR_RUNTIME_ERROR" : {
"message" : [
- "Error instantiating GRPC interceptor: <msg>"
+ "Error instantiating GRPC interceptor: <msg>."
+ ]
+ },
+ "INVALID_COMMAND_WRITE_INVALID_BUCKET_BY" : {
+ "message" : [
+ "BucketBy must specify a bucket count > 0, received <bucket>
instead."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT" : {
+ "message" : [
+ "Deduplicate must be called with either all or a subset of column
names to deduplicate."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT_COLUMN" : {
+ "message" : [
+ "Invalid column name used for Deduplicate: <col>."
+ ]
+ },
+ "INVALID_PLAN_EMPTY_INPUT" : {
+ "message" : [
+ "Input relation must not be empty."
+ ]
+ },
+ "INVALID_PLAN_INPUT" : {
+ "message" : [
+ "Error transforming Spark Connect plan: <msg>."
+ ]
+ },
+ "INVALID_PLAN_INVALID_ALIAS" : {
+ "message" : [
+ "Alias expressions with more than 1 identifier must not use optional
metadata."
+ ]
+ },
+ "INVALID_PLAN_INVALID_DATA_SOURCE" : {
+ "message" : [
+ "Read from DataSource requires a format parameter."
+ ]
+ },
+ "INVALID_PLAN_INVALID_JOIN_CONDITION" : {
+ "message" : [
+ "Using columns or join conditions cannot be set at the same time in
Join."
+ ]
+ },
+ "INVALID_PLAN_INVALID_SET_OPERATION" : {
+ "message" : [
+ "Invalid Set operation: <type> does not support <param>."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_EMPTY" : {
+ "message" : [
+ "Values must contains at least 1 item."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_SIZE" : {
+ "message" : [
+ "When values contains more than 1 items, values and cols should have
the same length."
+ ]
+ },
+ "INVALID_PLAN_UNKNOWN_RELATION" : {
+ "message" : [
+ "Relation: <param> not supported."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_DATA_SOURCE" : {
+ "message" : [
+ "Unsupported input data source: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_EXPRESSION_TYPE" : {
+ "message" : [
+ "Unsupported expression type: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_JOIN_TYPE" : {
+ "message" : [
+ "Unsupported Join type: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_LITERAL_TYPE" : {
+ "message" : [
+ "Unsupported Literal type: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_SET_OPERATION" : {
+ "message" : [
+ "Unsupported Set operation: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_TYPE_CONVERSION" : {
Review Comment:
Check this error class, please.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -132,7 +132,97 @@
},
"INTERCEPTOR_RUNTIME_ERROR" : {
"message" : [
- "Error instantiating GRPC interceptor: <msg>"
+ "Error instantiating GRPC interceptor: <msg>."
+ ]
+ },
+ "INVALID_COMMAND_WRITE_INVALID_BUCKET_BY" : {
+ "message" : [
+ "BucketBy must specify a bucket count > 0, received <bucket>
instead."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT" : {
+ "message" : [
+ "Deduplicate must be called with either all or a subset of column
names to deduplicate."
+ ]
+ },
+ "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT_COLUMN" : {
+ "message" : [
+ "Invalid column name used for Deduplicate: <col>."
+ ]
+ },
+ "INVALID_PLAN_EMPTY_INPUT" : {
+ "message" : [
+ "Input relation must not be empty."
+ ]
+ },
+ "INVALID_PLAN_INPUT" : {
+ "message" : [
+ "Error transforming Spark Connect plan: <msg>."
+ ]
+ },
+ "INVALID_PLAN_INVALID_ALIAS" : {
+ "message" : [
+ "Alias expressions with more than 1 identifier must not use optional
metadata."
+ ]
+ },
+ "INVALID_PLAN_INVALID_DATA_SOURCE" : {
+ "message" : [
+ "Read from DataSource requires a format parameter."
+ ]
+ },
+ "INVALID_PLAN_INVALID_JOIN_CONDITION" : {
+ "message" : [
+ "Using columns or join conditions cannot be set at the same time in
Join."
+ ]
+ },
+ "INVALID_PLAN_INVALID_SET_OPERATION" : {
+ "message" : [
+ "Invalid Set operation: <type> does not support <param>."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_EMPTY" : {
+ "message" : [
+ "Values must contains at least 1 item."
+ ]
+ },
+ "INVALID_PLAN_TRANSFORM_NA_FILL_SIZE" : {
+ "message" : [
+ "When values contains more than 1 items, values and cols should have
the same length."
+ ]
+ },
+ "INVALID_PLAN_UNKNOWN_RELATION" : {
+ "message" : [
+ "Relation: <param> not supported."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_DATA_SOURCE" : {
+ "message" : [
+ "Unsupported input data source: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_EXPRESSION_TYPE" : {
+ "message" : [
+ "Unsupported expression type: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_JOIN_TYPE" : {
+ "message" : [
+ "Unsupported Join type: <type>."
+ ]
+ },
+ "INVALID_PLAN_UNSUPPORTED_LITERAL_TYPE" : {
Review Comment:
Please, add a test for this error class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
