grundprinzip commented on code in PR #38793:
URL: https://github.com/apache/spark/pull/38793#discussion_r1034295175
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -242,6 +243,17 @@ class SparkConnectPlanner(session: SparkSession) {
.logicalPlan
}
+ private def transformWithColumns(rel: proto.WithColumns): LogicalPlan = {
+ val (names, cols) =
+ rel.getNameExprListList.asScala
+ .map(e => (e.getName(0), Column(transformExpression(e.getExpr))))
Review Comment:
Let's not use the current crude way of doing error handling as an excuse to
not do server side validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
