HyukjinKwon commented on code in PR #38844:
URL: https://github.com/apache/spark/pull/38844#discussion_r1035468735
##########
python/pyspark/sql/connect/column.py:
##########
@@ -29,6 +29,17 @@
from pyspark.sql.connect.client import SparkConnectClient
import pyspark.sql.connect.proto as proto
+# TODO: solve the circular import between _typing and this class if we want to
Review Comment:
Should ideally have a JIRA for each todo.
BTW, we can avoid the circular import by adding this import under `if
TYPE_CHECKING`, and use the hint with strings. e.g.) `Union["PrimitiveType",
"Column"])`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
