amaliujia commented on code in PR #38836:
URL: https://github.com/apache/spark/pull/38836#discussion_r1035500538
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -466,6 +467,35 @@ message NADrop {
}
+// Replaces old values with the corresponding values.
+// It will invoke 'Dataset.na.replace' (same as 'DataFrameNaFunctions.replace')
+// to compute the results.
+message NAReplace {
+ // (Required) The input relation.
+ Relation input = 1;
+
+ // (Optional) List of column names to consider.
+ //
+ // When it is empty, all the type-compatible columns in the input relation
will be considered.
+ repeated string cols = 2;
+
+ // (Optional) The value replacement mapping.
+ repeated Replacement replacements = 3;
+
+ message Replacement {
+ // (Required) The old value.
+ //
+ // Only 4 data types are supported now: null, bool, double, string.
+ Expression.Literal old_value = 1;
Review Comment:
Question:
How does proto now encode a `NULL`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
