mridulm commented on code in PR #38711:
URL: https://github.com/apache/spark/pull/38711#discussion_r1035515024
##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -383,8 +383,8 @@ private[spark] class DAGScheduler(
/**
* Called by the TaskSetManager when it decides a speculative task is needed.
*/
- def speculativeTaskSubmitted(task: Task[_]): Unit = {
- eventProcessLoop.post(SpeculativeTaskSubmitted(task))
+ def speculativeTaskSubmitted(task: Task[_], taskIndex: Int = -1): Unit = {
+ eventProcessLoop.post(SpeculativeTaskSubmitted(task, taskIndex))
Review Comment:
For the specific purposes here, even though they are different, they should
work the same ?
My concern is similar to @Ngone51's comment below - we should minimize
change to developer api - and given we can use `partitionId` instead, I would
rely on that instead.
(Do let me know if we cant !)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
