cloud-fan commented on code in PR #38750: URL: https://github.com/apache/spark/pull/38750#discussion_r1035869504
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.types + +import org.apache.spark.sql.types._ + +sealed abstract class PhysicalDataType + +case class PhysicalArrayType(elementType: DataType, containsNull: Boolean) extends PhysicalDataType + +case class PhysicalBinaryType() extends PhysicalDataType Review Comment: for physical types without parameters, shall we follow logical type and have both class and object? ``` class LongType private() ... case object LongType extends LongType ``` The benefit is: it's a singleton and we can save memory usage. The matching code in Scala can be ``` if (dt == PhysicalBinaryType).. pdt match { case PhysicalBinaryType => ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
