anchovYu commented on code in PR #38851:
URL: https://github.com/apache/spark/pull/38851#discussion_r1036272043
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2109,6 +2110,39 @@ class Analyzer(override val catalogManager:
CatalogManager)
}
}
+ /**
+ * Resolves `UnresolvedAttribute` to `OuterReference` if we are resolving
subquery plans (when
+ * `AnalysisContext.get.outerPlan` is set). Note that, this rule must be run
after
+ * `ResolveReferences` and `ResolveMissingReferences`, as outer reference
should be the last
+ * resort during column resolution.
+ */
+ object ResolveOuterReferences extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = {
+ // Only apply this rule if we are resolving subquery plans.
+ if (AnalysisContext.get.outerPlan.isEmpty) return plan
+
+ val preparedPlan = ResolveMissingReferences(ResolveReferences(plan))
Review Comment:
Is applying these rules once enough? e.g. is it possible that the
application of `ResolveMissingReferences` makes more attributes resolvable by
`ResolveReferences` and `ResolveMissingReferences` can be applied another time,
so forth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
