cloud-fan commented on code in PR #38799:
URL: https://github.com/apache/spark/pull/38799#discussion_r1036856699
##########
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q44/simplified.txt:
##########
@@ -13,51 +13,63 @@ TakeOrderedAndProject [rnk,best_performing,worst_performing]
Filter [rnk,item_sk]
InputAdapter
Window [rank_col]
- WholeStageCodegen (3)
- Sort [rank_col]
- InputAdapter
- Exchange #1
- WholeStageCodegen (2)
- Filter [rank_col]
- Subquery #1
- WholeStageCodegen (2)
- HashAggregate
[ss_store_sk,sum,count] [avg(UnscaledValue(ss_net_profit)),rank_col,sum,count]
- InputAdapter
- Exchange [ss_store_sk] #3
- WholeStageCodegen (1)
- HashAggregate
[ss_store_sk,ss_net_profit] [sum,count,sum,count]
- Project
[ss_store_sk,ss_net_profit]
- Filter
[ss_store_sk,ss_addr_sk]
- ColumnarToRow
- InputAdapter
- Scan parquet
spark_catalog.default.store_sales
[ss_addr_sk,ss_store_sk,ss_net_profit,ss_sold_date_sk]
- HashAggregate [ss_item_sk,sum,count]
[avg(UnscaledValue(ss_net_profit)),item_sk,rank_col,sum,count]
- InputAdapter
- Exchange [ss_item_sk] #2
- WholeStageCodegen (1)
- HashAggregate
[ss_item_sk,ss_net_profit] [sum,count,sum,count]
- Project
[ss_item_sk,ss_net_profit]
- Filter [ss_store_sk]
- ColumnarToRow
- InputAdapter
- Scan parquet
spark_catalog.default.store_sales
[ss_item_sk,ss_store_sk,ss_net_profit,ss_sold_date_sk]
+ WindowGroupLimit [rank_col]
+ WholeStageCodegen (3)
+ Sort [rank_col]
+ InputAdapter
+ Exchange #1
+ WindowGroupLimit [rank_col]
Review Comment:
we should support whole-stage-codegen for it. This can be done later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
