cloud-fan commented on code in PR #38777:
URL: https://github.com/apache/spark/pull/38777#discussion_r1036882653
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala:
##########
@@ -272,7 +272,10 @@ object FileSourceStrategy extends Strategy with
PredicateHelper with Logging {
case FileFormat.ROW_INDEX =>
fileFormatReaderGeneratedMetadataColumns
.find(_.name == FileFormat.ROW_INDEX_TEMPORARY_COLUMN_NAME)
- .get.withName(FileFormat.ROW_INDEX)
+ // Change the `_tmp_metadata_row_index` to `row_index`,
+ // and also change the nullability to not nullable,
+ // which is consistent with the nullability of `row_index`
field
+ .get.withName(FileFormat.ROW_INDEX).withNullability(false)
Review Comment:
shall we update `fileFormatReaderGeneratedMetadataColumns` to set nullablity
as false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
