srowen commented on code in PR #38901:
URL: https://github.com/apache/spark/pull/38901#discussion_r1038978948
##########
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala:
##########
@@ -85,7 +85,8 @@ private[spark] class CoarseGrainedExecutorBackend(
logInfo("Connecting to driver: " + driverUrl)
try {
- if (PlatformDependent.directBufferPreferred() &&
+ if (env.conf.getBoolean("spark.shuffle.io.preferDirectBufs", true) &&
Review Comment:
Should this check be 'and' or 'or'? how is it implemented elsewhere? that
is, should 'true' or 'false' setting of this value override the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
