LuciferYang commented on code in PR #38711: URL: https://github.com/apache/spark/pull/38711#discussion_r1039157936
########## core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala: ########## @@ -55,7 +55,8 @@ case class SparkListenerTaskGettingResult(taskInfo: TaskInfo) extends SparkListe @DeveloperApi case class SparkListenerSpeculativeTaskSubmitted( Review Comment: > Interesting option, but I would not prefer it to be modifiable by users - given it is a developer api. One option would be to do something like: > > ``` > > // modify json protocol, etc to > private[spark] var _taskIndex: Int = -1 > > def taskIndex: Int = _taskIndex > ``` > > +CC @jiangxb1987 who had worked on this in the past. Thoughts @Ngone51 I think this is ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
