[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0

Mon, 05 Dec 2022 23:05:52 -0800 


panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670


##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" 
% "9.3"
 // checkstyle uses guava 31.0.1-jre.
 libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
 
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")

Review Comment:
   **They are consistent**
   
   ## The comparison steps are as follows:
   1../build/sbt connect/assembly
   2.cd connector/connect/server/target/scala-2.12
   3.mkdir tmp & cd tmp
   4.cp ../spark-connect-assembly-3.4.0-SNAPSHOT.jar .
   5.jar -xvf spark-connect-assembly-3.4.0-SNAPSHOT.jar
   6.sort and compare all "*.class" "*.xml" "*.properties"(name & size)
   (When 1.2.0) 
   find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > 
sbt-assembly_1.2.0.txt
   find . -name "*.xml" | sort | xargs ls -al | awk '{print $9" "$5}' > 
sbt-assembly_xml_1.2.0.txt
   find . -name "*.properties" | sort | xargs ls -al | awk '{print $9" "$5}' > 
sbt-assembly_properties_1.2.0.txt
   
   (When 2.0.0) 
   find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > 
sbt-assembly_2.0.0.txt
   find . -name "*.xml" | sort | xargs ls -al | awk '{print $9" "$5}' > 
sbt-assembly_xml_2.0.0.txt
   find . -name "*.properties" | sort | xargs ls -al | awk '{print $9" "$5}' > 
sbt-assembly_properties_2.0.0.txt
   
   7.compare sbt-assembly_1.2.0.txt with bt-assembly_2.0.0.txt
   
   ## Result:
   A.class file
   <img width="1353" alt="image" 
src="https://user-images.githubusercontent.com/15246973/205839632-22145053-db82-452d-8488-031134505678.png";>
   
   B.xml file
   <img width="1238" alt="image" 
src="https://user-images.githubusercontent.com/15246973/205843551-2fc48b3e-d490-44b8-8460-556846177fd0.png";>
   
   C.properties file
   <img width="1285" alt="image" 
src="https://user-images.githubusercontent.com/15246973/205843462-e292fdcb-fe32-4752-9529-8ba9330957d7.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to