grundprinzip commented on code in PR #38883:
URL: https://github.com/apache/spark/pull/38883#discussion_r1041316676
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -397,7 +397,7 @@ class SparkConnectPlanner(session: SparkSession) {
}
private def transformUnresolvedExpression(exp: proto.Expression):
UnresolvedAttribute = {
- UnresolvedAttribute(exp.getUnresolvedAttribute.getUnparsedIdentifier)
+
UnresolvedAttribute.quotedString(exp.getUnresolvedAttribute.getUnparsedIdentifier)
Review Comment:
> This is tricky... it's `CatalystSqlParser.parseMultipartIdentifier` v.s.
`parseAttributeName` under the hood. Ideally `parseMultipartIdentifier` is more
standard but following existing pyspark behavior is more important.
This follows not just Pyspark but the Column API in Scala as well. There the
string constructor uses exactly this method call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
