wineternity commented on PR #38702:
URL: https://github.com/apache/spark/pull/38702#issuecomment-1340463701
> The change looks good to me. +CC @Ngone51
>
> Btw, do you also want to remove the `if (event.taskInfo == null) {` check
in beginning of `onTaskEnd` ?
>
> Make it a precondition check ? `Preconditions.checkNotNull(event.taskInfo)`
Yes, it can be change to a precondition check. Maybe I can change it in a
new pr after test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
