LuciferYang commented on code in PR #38865:
URL: https://github.com/apache/spark/pull/38865#discussion_r1041982107
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala:
##########
@@ -5237,6 +5237,59 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSparkSession {
)
)
}
+
+ test("SPARK-41232 array_append -> Unit Test cases for the function ") {
+ val df1 = Seq((Array[Int](3, 2, 5, 1, 2), 3)).toDF("a", "b")
Review Comment:
But for an existing function, such as `ArrayUnion`:
```
val df = Seq((Array(1.0, 2.0, 3.0), Array(4, 2))).toDF("a", "b")
val rows = df.select(array_union($"a", $"b")).collect()
```
the `rows` will be `[WrappedArray(1.0, 2.0, 3.0, 4.0)]`
So, I think `array_append` can support similar cast behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
