amaliujia commented on code in PR #38961: URL: https://github.com/apache/spark/pull/38961#discussion_r1042749456
########## python/pyspark/sql/connect/functions.py: ########## @@ -90,7 +90,10 @@ def col(col: str) -> Column: def lit(col: Any) -> Column: - return Column(LiteralExpression(col)) + if isinstance(col, Column): + return col Review Comment: Ok it seems that Scala `lit` is already doing this so should be ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
