amaliujia commented on code in PR #38970:
URL: https://github.com/apache/spark/pull/38970#discussion_r1042808896
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -43,7 +43,11 @@ message Expression {
Expression expr = 1;
// (Required) the data type that the expr to be casted to.
- DataType cast_to_type = 2;
+ oneof cast_to_type {
Review Comment:
Ah thanks. I didn't know this way to evolve the proto.
Given Spark Connect is still alpha component though for now we don't need to
be enforced to maintain the backwards compatibility.
But when we are ready to leave from the alpha component then we should
follow this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
