zsxwing commented on code in PR #38823:
URL: https://github.com/apache/spark/pull/38823#discussion_r1042918249
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableProvider.java:
##########
@@ -93,4 +93,18 @@ default Transform[]
inferPartitioning(CaseInsensitiveStringMap options) {
default boolean supportsExternalMetadata() {
return false;
}
+
+ /**
+ * Returns true if the source supports defining generated columns upon table
creation in SQL.
+ * When false: any create/replace table statements with a generated column
defined in the table
+ * schema will throw an exception during analysis.
+ *
+ * A generated column is defined with syntax: {@code colName colType
GENERATED ALWAYS AS (expr)}
+ * The generation expression is stored in the column metadata with key
"generationExpression".
+ *
+ * Override this method to allow defining generated columns in
create/replace table statements.
+ */
+ default boolean supportsGeneratedColumnsOnCreation() {
Review Comment:
We can just call this method `supportsGeneratedColumns`, so that we don't
need to add a new API if we want to extend generated columns in other
statements in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
