zhengruifeng commented on code in PR #38973:
URL: https://github.com/apache/spark/pull/38973#discussion_r1043076491
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -309,6 +310,28 @@ class SparkConnectPlanner(session: SparkSession) {
UnresolvedHint(rel.getName, params, transformRelation(rel.getInput))
}
+ private def transformMelt(rel: proto.Melt): LogicalPlan = {
+ val ids = rel.getIdsList.asScala.toArray.map { expr =>
+ Column(transformExpression(expr))
+ }
+
+ if (rel.getValuesList.isEmpty) {
+ Dataset
Review Comment:
since `melt` is just a alias for `unpivot`, and `unpivot` happens to have a
[dedicated logical
plan](https://github.com/apache/spark/blob/a80899f8bef84bb471606f0bbef889aa5e81628b/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L2072-L2085),
so please just use the plan `Unpivot` here instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
