baganokodo2022 commented on code in PR #38922: URL: https://github.com/apache/spark/pull/38922#discussion_r1043925095
########## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufOptions.scala: ########## @@ -38,6 +38,12 @@ private[sql] class ProtobufOptions( val parseMode: ParseMode = parameters.get("mode").map(ParseMode.fromString).getOrElse(FailFastMode) + + val circularReferenceType: String = parameters.getOrElse("circularReferenceType", "FIELD_NAME") Review Comment: @rangadi , the issue is that protobuf is designed for interactions between micro services. Protobuf schemas are long existing before we introduced Delta lake to the corporate. In many cases, we have to comprise for the needs of micro services, not the other way around. Service developers typically are not motivated or willing to take the risk to revise their data model for data analytics purposes. I will compile a proto schema shortly. cc @SandishKumarHN thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org