pan3793 commented on code in PR #38985:
URL: https://github.com/apache/spark/pull/38985#discussion_r1043983985
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala:
##########
@@ -275,7 +275,7 @@ private[spark] object KubernetesConf {
.toLowerCase(Locale.ROOT)
.replaceAll("[^a-z0-9\\-]", "-")
.replaceAll("-+", "-"),
- "",
+ "-", // avoid using empty string, see
https://issues.apache.org/jira/browse/LANG-1463
Review Comment:
Yes, LANG-1463 is fixed at 3.10 and Apache Spark is using 3.12. Removed the
confusing comment. And I explained why I propose this change in PR description,
> Strictly speaking, it's not an issue of Spark ... but considering the
following facts ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
