beliefer commented on PR #38874:
URL: https://github.com/apache/spark/pull/38874#issuecomment-1343731612
Basically, the implementation looks good. But we can use
`RuntimeReplaceable` to simplify this PR.
`ArrayCompact` can reuse `ArrayRemove` and implement `RuntimeReplaceable`.
```
> SELECT array_compact(array(1, 2, 3, null));
[1,2,3]
```
equals to
```
> SELECT array_remove(array(1, 2, 3, null), null);
[1,2,3]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
