tomvanbussel commented on code in PR #38979:
URL: https://github.com/apache/spark/pull/38979#discussion_r1044271991
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -371,6 +371,22 @@ class SparkConnectPlanner(session: SparkSession) {
}
}
+ private def parseDatatypeString(sqlText: String): DataType = {
+ var dataType: DataType = null
+ try {
+ dataType = session.sessionState.sqlParser.parseTableSchema(sqlText)
+ } catch {
+ case e1: ParseException =>
+ try {
+ dataType = session.sessionState.sqlParser.parseDataType(sqlText)
+ } catch {
+ case e2: ParseException =>
+ dataType =
session.sessionState.sqlParser.parseDataType(s"struct<${sqlText.strip}>")
+ }
+ }
+ dataType
Review Comment:
Nit: This can be simplified, and should throw the original exception.
```scala
val parser = session.sessionState.sqlParser
try {
parser.parseTableSchema(sqlText)
} catch {
case e: ParseException =>
try {
parser.parseDataType(sqlText)
} catch {
case _: ParseException =>
try {
parser.parseDataType(s"struct<${sqlText.strip}>")
} catch {
case _: ParseException =>
throw e
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
