amaliujia commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1044705096
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -305,7 +305,11 @@ class SparkConnectPlanner(session: SparkSession) {
}
private def transformHint(rel: proto.Hint): LogicalPlan = {
- val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq
+ val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq.map{
+ case name: String => UnresolvedAttribute(name)
+ case l: Long => l.toInt
Review Comment:
This becomes a bit tricky: Python is just one of the clients. Scala also has
a client in the future.
I actually not sure what is the best way to deal with cross language
difference. cc @HyukjinKwon any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
