otterc commented on code in PR #36165:
URL: https://github.com/apache/spark/pull/36165#discussion_r1044862699
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -26,13 +26,23 @@
"outputBytes" : 0,
"outputRecords" : 0,
"shuffleRemoteBlocksFetched" : 0,
- "shuffleLocalBlocksFetched" : 80,
+ "shuffleLocalBlocksFetched" : 0,
Review Comment:
Same here. Why did we change the value?
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -26,13 +26,23 @@
"outputBytes" : 0,
"outputRecords" : 0,
"shuffleRemoteBlocksFetched" : 0,
- "shuffleLocalBlocksFetched" : 80,
+ "shuffleLocalBlocksFetched" : 0,
"shuffleFetchWaitTime" : 0,
"shuffleRemoteBytesRead" : 0,
"shuffleRemoteBytesReadToDisk" : 0,
- "shuffleLocalBytesRead" : 3760,
- "shuffleReadBytes" : 3760,
- "shuffleReadRecords" : 100,
+ "shuffleLocalBytesRead" : 0,
+ "shuffleReadBytes" : 0,
+ "shuffleReadRecords" : 0,
Review Comment:
Same for these.
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -76,12 +86,24 @@
},
"shuffleReadMetrics" : {
"remoteBlocksFetched" : 0,
- "localBlocksFetched" : 8,
+ "localBlocksFetched" : 0,
"fetchWaitTime" : 0,
"remoteBytesRead" : 0,
"remoteBytesReadToDisk" : 0,
- "localBytesRead" : 376,
- "recordsRead" : 10
+ "localBytesRead" : 0,
+ "recordsRead" : 0,
Review Comment:
this as well
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -127,12 +149,24 @@
},
"shuffleReadMetrics" : {
"remoteBlocksFetched" : 0,
- "localBlocksFetched" : 8,
+ "localBlocksFetched" : 0,
"fetchWaitTime" : 0,
"remoteBytesRead" : 0,
"remoteBytesReadToDisk" : 0,
- "localBytesRead" : 376,
- "recordsRead" : 10
+ "localBytesRead" : 0,
+ "recordsRead" : 0,
Review Comment:
existing value changed
##########
core/src/test/resources/HistoryServerExpectations/failed_stage_list_json_expectation.json:
##########
@@ -66,5 +76,7 @@
"MajorGCCount" : 0,
"MajorGCTime" : 0,
"TotalGCTime" : 0
- }
-} ]
+ },
+ "isPushBasedShuffleEnabled" : false,
+ "shuffleMergersCount" : 0
+} ]
Review Comment:
No newline at the end of file
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -76,12 +86,24 @@
},
"shuffleReadMetrics" : {
"remoteBlocksFetched" : 0,
- "localBlocksFetched" : 8,
+ "localBlocksFetched" : 0,
Review Comment:
here as well
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -178,12 +212,24 @@
},
"shuffleReadMetrics" : {
"remoteBlocksFetched" : 0,
- "localBlocksFetched" : 8,
+ "localBlocksFetched" : 0,
Review Comment:
same here
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -178,12 +212,24 @@
},
"shuffleReadMetrics" : {
"remoteBlocksFetched" : 0,
- "localBlocksFetched" : 8,
+ "localBlocksFetched" : 0,
"fetchWaitTime" : 0,
"remoteBytesRead" : 0,
"remoteBytesReadToDisk" : 0,
- "localBytesRead" : 372,
- "recordsRead" : 9
+ "localBytesRead" : 0,
+ "recordsRead" : 0,
Review Comment:
same here
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -127,12 +149,24 @@
},
"shuffleReadMetrics" : {
"remoteBlocksFetched" : 0,
- "localBlocksFetched" : 8,
+ "localBlocksFetched" : 0,
Review Comment:
value is changed
##########
core/src/test/resources/HistoryServerExpectations/failed_stage_list_json_expectation.json:
##########
@@ -27,13 +27,23 @@
"outputBytes" : 0,
"outputRecords" : 0,
"shuffleRemoteBlocksFetched" : 0,
- "shuffleLocalBlocksFetched" : 64,
- "shuffleFetchWaitTime" : 1,
+ "shuffleLocalBlocksFetched" : 0,
+ "shuffleFetchWaitTime" : 0,
Review Comment:
Why are we changing these values?
##########
core/src/test/resources/HistoryServerExpectations/one_stage_json_with_partitionId_expectation.json:
##########
@@ -620,5 +750,7 @@
"MajorGCCount" : 0,
"MajorGCTime" : 0,
"TotalGCTime" : 0
- }
+ },
+ "isPushBasedShuffleEnabled" : false,
+ "shuffleMergersCount" : 0
} ]
Review Comment:
We can add a new line at the end of file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
