HyukjinKwon commented on code in PR #39015:
URL: https://github.com/apache/spark/pull/39015#discussion_r1044952894
##########
dev/sparktestsupport/utils.py:
##########
@@ -84,7 +84,7 @@ def identify_changed_files_from_git_commits(patch_sha,
target_branch=None, targe
["git", "diff", "--name-only", patch_sha, diff_target],
universal_newlines=True
)
# Remove any empty strings
- return [f for f in raw_output.split("\n") if f]
+ return [f for f in raw_output.split("\n") if f and not
f.endswith("README.md")]
Review Comment:
Should we maybe fix it in L48 `if filename in ("appveyor.yml",):` at
`determine_modules_for_files` above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
