viirya commented on code in PR #38888:
URL: https://github.com/apache/spark/pull/38888#discussion_r1045190749
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala:
##########
@@ -650,11 +650,17 @@ case object UnresolvedSeed extends LeafExpression with
Unevaluable {
* An intermediate expression to hold a resolved (nested) column. Some rules
may need to undo the
* column resolution and use this expression to keep the original column name.
*/
-case class TempResolvedColumn(child: Expression, nameParts: Seq[String])
extends UnaryExpression
+case class TempResolvedColumn(
+ child: Expression,
+ nameParts: Seq[String],
+ hasTried: Boolean = false) extends LeafExpression
with Unevaluable {
+ // If it has been tried to be resolved but failed, mark it as unresolved so
that other rules can
+ // try to resolve it again.
Review Comment:
This expression for its purpose is to hold original column name for a
resolved column. So the column resolution can be undo. With this new
`hasTried`, it becomes something that is resolved but also failed to resolve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
