cloud-fan commented on code in PR #38969:
URL: https://github.com/apache/spark/pull/38969#discussion_r1045760905
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala:
##########
@@ -785,7 +785,11 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
testMetricsInSparkPlanOperator(exchanges.head,
Map("dataSize" -> 3200, "shuffleRecordsWritten" -> 100))
- testMetricsInSparkPlanOperator(exchanges(1), Map("dataSize" -> 0,
"shuffleRecordsWritten" -> 0))
+ // `testData2.filter($"b" === 0)` is an empty relation.
+ // The exchange doesn't serialize any bytes.
+ // The SQLMetric keeps initial value.
+ testMetricsInSparkPlanOperator(exchanges(1),
+ Map("dataSize" -> -1, "shuffleRecordsWritten" -> 0))
Review Comment:
what do we show in the SQL UI? printing -1 as the size is a bit weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
