otterc commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r1046545776
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -593,6 +607,9 @@ public void onData(String streamId, ByteBuffer buf) {
@Override
public void onComplete(String streamId) {
+ if (isTooLate) {
+ pushMergeMetrics.tooLateResponses.mark();
+ }
Review Comment:
Actually in our 2.3 version, we were incrementing this metric whenever, the
server was responding to the client that the block is tooLate. In `onFailure`
we don't respond to the client with `TooLate`. However, these metrics are the
server's view so I think you are right. We should increment outside the
callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
