rmcyang commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r1046602772
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1197,15 +1230,15 @@ public void onData(String streamId, ByteBuffer buf)
throws IOException {
appShuffleInfo.shuffles.get(partitionInfo.appAttemptShuffleMergeId.shuffleId);
if (isStale(info,
partitionInfo.appAttemptShuffleMergeId.shuffleMergeId) ||
Review Comment:
Thanks for the suggestion. It seems that a stale block push can appear
during indeterminate stage retries
([reference](https://github.com/apache/spark/blob/05cd5f97c3dea25dacdbdb319243cdab9667c774/common/network-common/src/main/java/org/apache/spark/network/server/BlockPushNonFatalFailure.java#L132)).
Not sure how necessary capturing this would be, it can be captured similar to
capturing `lateBlockPushes` @mridulm .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
