beliefer commented on code in PR #38799: URL: https://github.com/apache/spark/pull/38799#discussion_r1046885232
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InsertWindowGroupLimitSuite.scala: ########## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.Row +import org.apache.spark.sql.catalyst.dsl.expressions._ +import org.apache.spark.sql.catalyst.dsl.plans._ +import org.apache.spark.sql.catalyst.expressions.{CurrentRow, DenseRank, Literal, NthValue, NTile, Rank, RowFrame, RowNumber, SpecifiedWindowFrame, UnboundedPreceding} +import org.apache.spark.sql.catalyst.plans.PlanTest +import org.apache.spark.sql.catalyst.plans.logical.{LocalRelation, LogicalPlan} +import org.apache.spark.sql.catalyst.rules.RuleExecutor +import org.apache.spark.sql.internal.SQLConf + +class InsertWindowGroupLimitSuite extends PlanTest { + private object Optimize extends RuleExecutor[LogicalPlan] { + val batches = + Batch("Insert WindowGroupLimit", FixedPoint(10), + CollapseProject, + RemoveNoopOperators, + PushDownPredicates, + InsertWindowGroupLimit) :: Nil + } + + private object WithoutOptimize extends RuleExecutor[LogicalPlan] { + val batches = + Batch("Insert WindowGroupLimit", FixedPoint(10), + CollapseProject, + RemoveNoopOperators, + PushDownPredicates) :: Nil + } + + private val testRelation = LocalRelation.fromExternalRows( + Seq("a".attr.int, "b".attr.int, "c".attr.int), + 1.to(10).map(i => Row(i % 3, 2, i))) + private val a = testRelation.output(0) + private val b = testRelation.output(1) + private val c = testRelation.output(2) + private val rankLikeFunctions = Seq(RowNumber(), Rank(c :: Nil), DenseRank(c :: Nil)) + private val unsupportedFunctions = Seq(new NthValue(c, Literal(1)), new NTile()) + private val windowFrame = SpecifiedWindowFrame(RowFrame, UnboundedPreceding, CurrentRow) + private val supportedConditions = Seq($"rn" === 2, $"rn" < 3, $"rn" <= 2) + private val unsupportedConditions = Seq($"rn" > 2, $"rn" === 1 || b > 2) Review Comment: Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
