HyukjinKwon commented on code in PR #38876:
URL: https://github.com/apache/spark/pull/38876#discussion_r1047077651
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMessages.scala:
##########
@@ -63,7 +63,8 @@ private[spark] object BlockManagerMessages {
localDirs: Array[String],
maxOnHeapMemSize: Long,
maxOffHeapMemSize: Long,
- sender: RpcEndpointRef)
+ sender: RpcEndpointRef,
+ isReRegister: Boolean)
Review Comment:
Not sure why and how but seems like branch-3.3 complains about this in MiMa
binary compatibility test
(https://github.com/apache/spark/actions/runs/3683054520/jobs/6231260546).
```
[error] spark-core: Failed binary compatibility check against
org.apache.spark:spark-core_2.13:3.2.0! Found 4 potential problems (filtered
921)
[error] * method
copy(org.apache.spark.storage.BlockManagerId,Array[java.lang.String],Long,Long,org.apache.spark.rpc.RpcEndpointRef)org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager
in class org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager
does not have a correspondent in current version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager.copy")
[error] * method
this(org.apache.spark.storage.BlockManagerId,Array[java.lang.String],Long,Long,org.apache.spark.rpc.RpcEndpointRef)Unit
in class org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager
does not have a correspondent in current version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager.this")
[error] * the type hierarchy of object
org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager is different
in current version. Missing types {scala.runtime.AbstractFunction5}
[error] filter with:
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.storage.BlockManagerMessages$RegisterBlockManager$")
[error] * method
apply(org.apache.spark.storage.BlockManagerId,Array[java.lang.String],Long,Long,org.apache.spark.rpc.RpcEndpointRef)org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager
in object org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager
does not have a correspondent in current version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.BlockManagerMessages#RegisterBlockManager.apply")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
