zhengruifeng commented on code in PR #39035:
URL: https://github.com/apache/spark/pull/39035#discussion_r1047917636
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -147,6 +148,13 @@ message Expression {
repeated string target = 1;
}
+ // Represents all of the input attributes to a given relational operator,
for example in
+ // "SELECT `(id)?+.+` FROM ...".
+ message UnresolvedRegex {
+ // (Required) The column name used to extract column with regex.
+ string col_name = 1;
Review Comment:
not related to this PR, but I'm thinking we probably need to unify the
naming in protos at some moment. Since we are using `col_name`, `column_names`,
`cols`, `col1`, `col2` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
