SandishKumarHN commented on code in PR #38922:
URL: https://github.com/apache/spark/pull/38922#discussion_r1049175487
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala:
##########
@@ -92,14 +106,26 @@ object SchemaConverters {
MapType(keyType, valueType, valueContainsNull =
false).defaultConcreteType,
nullable = false))
case MESSAGE =>
- if (existingRecordNames.contains(fd.getFullName)) {
+ // Setting the circularReferenceDepth to 0 allows the field to be
recursed once, setting
+ // it to 1 allows it to be recursed twice, and setting it to 2 allows
it to be recursed
+ // thrice. circularReferenceDepth value greater than 2 is not allowed.
If the not
+ // specified, it will default to -1, which disables recursive fields.
+ val recordName = fd.getMessageType.getFullName
+ if (existingRecordNames.contains(recordName) &&
Review Comment:
@rangadi thanks for the review, I have made all changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
