grundprinzip commented on code in PR #39017:
URL: https://github.com/apache/spark/pull/39017#discussion_r1049953432
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -588,6 +588,22 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
comparePlans(connectPlan1, sparkPlan1)
}
+ test("Test RandomSplit") {
+ val splitRelations0 = connectTestRelation.randomSplit(Array[Double](1, 2,
3), 1)
Review Comment:
If I'm not mistaken all of the tests excercise the code path with
`force_stable_sort` it would be good to test without as well to make sure to
execute the else branch.
##########
python/pyspark/sql/tests/connect/test_connect_plan_only.py:
##########
@@ -228,6 +229,41 @@ def test_melt(self):
self.assertEqual(plan.root.unpivot.variable_column_name, "variable")
self.assertEqual(plan.root.unpivot.value_column_name, "value")
+ def test_random_split(self):
Review Comment:
```suggestion
def test_random_split(self):
# SPARK-41440: Support for Random split.
```
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -806,6 +806,20 @@ def test_unpivot(self):
.toPandas(),
)
+ def test_random_split(self):
Review Comment:
```suggestion
def test_random_split(self):
# SPARK-41440: Support for Random Split.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
